fix: match Unstable reimbursement UI to stable, powered by the hook - #2756
Merged
Merged
Conversation
Duplicate the stable PayrollEditEmployee reimbursement UI (useDataView table, EmptyData empty state, secondary Add button, draft grid) into UNSTABLE_PayrollEditEmployee for visual parity, fed by usePayrollEditEmployeeForm instead of a local field array/draft form. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # src/components/Payroll/UNSTABLE_PayrollEditEmployee/UNSTABLE_PayrollEditEmployee.tsx
serikjensen
enabled auto-merge
September 11, 2026 22:27
krisxcrash
approved these changes
Sep 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 11, 2026
The "creates employee, home address, and work address with correct payloads" test drives 13+ userEvent interactions before asserting three sequential mutations, relying on the 5000ms default test timeout. Under merge-queue CI load it tips over that budget and times out, even though it passes in the PR's own CI run. Give this heavy test an explicit 15000ms timeout, matching vitest's own guidance for long-running tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6yva3RizV7rBdXQKZ3QLj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores visual parity between the reimbursement UI in
UNSTABLE_PayrollEditEmployeeand the stablePayrollEditEmployee. During the RRoP hook migration, the Unstable reimbursement UI diverged into hand-rolledFlexrows (with an InfoIcon recurring tooltip) instead of the stable DataView-based table.This duplicates the stable reimbursement UI into a local
ReimbursementsSectionin the Unstable file, now powered byusePayrollEditEmployeeFormrather than a local field array/draft form:useDataViewtable with Description / Amount / Type columnsitemMenutrash-can remove, suppressed on recurring rowsEmptyDataempty state with a secondary "Add" CTAreimbursementDraftfields) + Save/CancelPer the temporary new-alongside-legacy strategy, the UI is intentionally duplicated, not abstracted into a shared component.
UNSTABLE_PayrollEditEmployeewill eventually replace the stable view.Notes
Testing
UNSTABLE_PayrollEditEmployeetests passpayrollRegularRateOfPay) and backend-dependent, so verified via the test suite rather than the dev serverScreen.Recording.2026-09-11.at.2.21.51.PM.mov
🤖 Generated with Claude Code