[Feature] 模组等的更新日志以及 HTMLRenderer 的完善 by ToobLac · Pull Request #6098 · HMCL-dev/HMCL

ToobLac · 2026-05-16T03:16:25Z

添加了下载模组、数据包等以及更新模组时显示更新日志的功能
Resolves #4685

具体变化：

以下载模组为例，在原来仅用作展示模组依赖项的页面中同时展示该版本更新日志并可跳转到版本发布界面
检查模组更新之后的表格中在最右侧添加“更新日志”列，点击单元格即可打开更新日志并可跳转到版本发布界面
添加打开链接页面的“复制”按钮
HTMLRenderer 的优化与完善，以及对 Markdown 的支持（引入了新依赖）

TODO：

可能不准确不地道，需要熟悉这些语言的人验证

# Conflicts: # HMCL/src/main/resources/assets/lang/I18N.properties # HMCL/src/main/resources/assets/lang/I18N_es.properties # HMCL/src/main/resources/assets/lang/I18N_ja.properties # HMCL/src/main/resources/assets/lang/I18N_lzh.properties # HMCL/src/main/resources/assets/lang/I18N_ru.properties # HMCL/src/main/resources/assets/lang/I18N_uk.properties # HMCL/src/main/resources/assets/lang/I18N_zh.properties # HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java

支持裸URL 修复更新日志过长时显示不全的问题

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java

Minecraft269

🤖 PR 审查报告 — PR #6098

审查模型: DeepSeek V4 (DeepSeek-V4-Pro)
审查维度: 安全漏洞 · 错误处理 · 类型设计 · API 设计
变更规模: 25 文件，+842 / −142 行

具体问题和修复建议已在上方代码行的 inline comment 中标注。以下为汇总。

📊 汇总

严重性	数量	类别
🔴 Critical	5	2 安全 + 3 静默失败
🟠 Important	6	类型设计 + 健壮性 + 一致性
🟡 Suggestion	4	代码质量

✅ 正面发现

HTMLRenderer 从旧式 switch 迁移到 switch expression — 代码现代化
图像加载同步→异步 — 修复阻塞 UI 的正确方向
Markdown 支持丰富 (Autolink/Strikethrough/Tables/Ins)
链式调用 API (return this) — 非破坏性流畅接口
SEMAPHORE 资源管理一致、正确
多语言支持周到（含文言文）

核心建议: 优先修复 C1(XSS绕过) + C2(URI方案注入) 两个安全漏洞，以及 C3/C4/C5 三个静默失败。

🤖 Generated with Claude Code | 审查引擎: DeepSeek V4

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/Controllers.java # HMCLCore/build.gradle.kts # gradle/libs.versions.toml

Minecraft269 · 2026-06-19T06:48:25Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces support for rendering and displaying addon changelogs in the UI, integrating the CommonMark library to parse Markdown into HTML and extending the HTMLRenderer to support tables, ordered lists, code blocks, and basic inline CSS. It also refactors RemoteMod.Type to RemoteMod.Source and adds changelog fetching to CurseForge and Modrinth repositories. The review feedback highlights a potential IndexOutOfBoundsException in the auto-sizing table height calculation and a potential NullPointerException in the HTML table cell value factory. Additionally, it suggests setting a constrained column resize policy for rendered tables and returning early when processing TextNodes to improve performance.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Glavo

本审查建议由 GPT-5 生成

已将具体审查建议标注在对应代码行。

# Conflicts: # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/curse/CurseForgeRemoteModRepository.java

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AddonCheckUpdatesTask.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AddonUpdatesPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java # HMCL/src/main/resources/assets/lang/I18N.properties # HMCL/src/main/resources/assets/lang/I18N_lzh.properties # HMCL/src/main/resources/assets/lang/I18N_zh.properties # HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/LocalAddonFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/LocalModFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/resourcepack/ResourcePackFolder.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/resourcepack/ResourcePackZipFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/RemoteMod.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/curse/CurseAddon.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/curse/CurseForgeRemoteModRepository.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modrinth/ModrinthRemoteModRepository.java # HMCLCore/src/main/java/org/jackhuang/hmcl/util/Lang.java

Minecraft269 · 2026-06-26T14:43:22Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces support for viewing addon changelogs by fetching them from remote repositories (CurseForge and Modrinth) and rendering them as HTML/Markdown using the CommonMark library. It adds a changelog viewer dialog to both the addon updates page and the download page, along with table rendering support in the HTML renderer. The review feedback highlights several issues: a potential NullPointerException in AddonUpdatesPage when retrieving the default cell factory, a performance anti-pattern in HTMLRenderer where UI nodes are instantiated inside CellValueFactory, a readability concern in a loop within HTMLRenderer, and an inaccurate HTML-vs-Markdown detection logic in StringUtils.convertToHtml.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-26T14:47:25Z

+    public static String convertToHtml(String str) {
+        if (str == null) return null;
+        if (isBlank(str)) return "";
+
+        /*
+        Firstly, we check if the string could be seen as HTML.
+
+        If so, we convert it to HTML document, then re-print it to a string to normalize spaces
+        (otherwise the parser may parse the HTML code as code blocks, which is not intended).
+        This will (hopefully) not break Markdown formats.
+
+        If not, we assume that the string is pure Markdown.
+         */
+        String either = Jsoup.isValid(str, all)
+                ? Jsoup.parse(str).outputSettings(new Document.OutputSettings().prettyPrint(false)).body().html()
+                : str;
+
+        return HTML_RENDERER.render(MD_PARSER.parse(either));
+    }


使用 Jsoup.isValid(str, all) 来判断输入是 HTML 还是 Markdown 是不准确的。

因为任何不包含任何 HTML 标签的纯文本或纯 Markdown 字符串（例如 This is **bold** text）在 Jsoup.isValid 中都会被判定为 true（因为它不包含任何不允许的标签）。这会导致纯 Markdown 文本也走入 HTML 的解析分支，从而可能导致一些特殊字符（如 <）被错误地转义或破坏。

此外，如果输入已经是 HTML，将其再次传入 Markdown 解析器 MD_PARSER 是多余且低效的，甚至可能导致 HTML 内部的文本被错误地解析为 Markdown 语法。

建议使用更健壮的方法来区分 HTML 和 Markdown：使用 Jsoup 解析字符串，并检查其 body 是否包含任何子元素（HTML 标签）。如果是 HTML，则直接返回清理后的 HTML；如果是 Markdown，则仅使用 MD_PARSER 进行解析。

public static String convertToHtml(String str) { if (str == null) return null; if (isBlank(str)) return ""; Document doc = Jsoup.parse(str); // 如果 body 中包含任何 HTML 元素，则视为 HTML if (!doc.body().children().isEmpty()) { return doc.outputSettings(new Document.OutputSettings().prettyPrint(false)).body().html(); } // 否则视为纯 Markdown return HTML_RENDERER.render(MD_PARSER.parse(str)); }

@Glavo CC

没太想好怎么处理这一堆东西，目前这坨逻辑用起来似乎没啥问题

难点在虽然 MD 渲染器能识别HTML，但根据 MD 规范，由至少四个空格开头的行会被识别为代码块，而JEI的更新日志是HTML格式且每行都有至少4个空格作为开头，导致MD渲染器无法正常渲染。所以只能出此下策，parse一遍再不加空格地转回来，从而识别这种难搞的玩意。

等下我完善好我的SKILL就让我的CC看看

等下我完善好我的SKILL就让我的CC看看

完善好了现在看看

# Conflicts: # HMCL/src/main/resources/assets/about/deps.json

Minecraft269

审查：`convertToHtml` 及关联代码

以下是针对 StringUtils.convertToHtml() 和相关文件的审查建议。总体来看功能实现正确，核心的 JEI HTML 缩进→代码块问题处理思路是合理的，但有几处可以改进。

审查重点

🔴 高优先级 — 逻辑/正确性问题
🟠 中优先级 — 代码质量/可维护性
🟡 低优先级 — 风格/注释

已验证没问题的 Gemini 建议

以下之前 AI 提出的建议经你驳回后确认无误：CSS image-pattern() 注入、isWhitespace() Unicode 覆盖、Modrinth projectType 重定向、#text+img 检测逻辑（Gemini 确实把逻辑理解反了）。

Calboot added 30 commits November 19, 2025 20:00

下载模组时展示更新日志

73b01ce

添加模组更新界面的更新日志

cffd3e0

代码格式

5a39c98

Merge branch 'HMCL-dev:main' into mod-changelog

3d514fe

中文支持&界面优化

5b3a705

多语言支持

404548d

可能不准确不地道，需要熟悉这些语言的人验证

update

d351523

Merge branch 'HMCL-dev:main' into mod-changelog

8fed3b7

Merge remote-tracking branch 'upstream/main' into mod-changelog

36c6661

update

cb3fc84

update

998c6d1

update

c9c7ea5

Merge remote-tracking branch 'upstream/main' into mod-changelog

f501b79

Merge remote-tracking branch 'upstream/main' into mod-changelog

71b0aae

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java

update

0973c76

HTML support & changelog cache

50a2aeb

Markdown

e3f05fb

update

b35897b

支持裸URL 修复更新日志过长时显示不全的问题

Add deps

1915cfd

update

212d8be

Merge branch 'HMCL-dev:main' into mod-changelog

e9cca3e

Merge branch 'HMCL-dev:main' into mod-changelog

853ef1f

Merge branch 'HMCL-dev:main' into mod-changelog

ce4d12a

Merge branch 'main' into mod-changelog

1005fcd

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java

update

9fd3efc

update

5f81a39

update

bdf6ef4

update

8ad29d1

Merge branch 'main' into mod-changelog

95922f1

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java

Minecraft269 reviewed Jun 13, 2026

View reviewed changes

ToobLac added 10 commits June 14, 2026 12:30

update

1acd344

update

0490b1c

update

de166c3

update

b570429

update & renaming

edb7b8a

update

d815131

update

57b3822

更新markdown解析逻辑

5d5031d

Merge remote-tracking branch 'upstream/main' into mod-changelog

c6a3531

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/Controllers.java # HMCLCore/build.gradle.kts # gradle/libs.versions.toml

update

52601fb

gemini-code-assist Bot reviewed Jun 19, 2026

View reviewed changes

update

e82810f

Glavo reviewed Jun 21, 2026

View reviewed changes

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/mod/RemoteModRepository.java Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/HTMLRenderer.java

ToobLac added 6 commits June 21, 2026 15:54

update

a52b0f6

update

8f71e2e

Merge remote-tracking branch 'upstream/main' into mod-changelog

549b2fe

# Conflicts: # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/curse/CurseForgeRemoteModRepository.java

update

f862fc8

complete merge

f68f782

gemini-code-assist Bot reviewed Jun 26, 2026

View reviewed changes

ToobLac added 2 commits June 27, 2026 17:39

update

6022665

update

453db58

ChouChiu mentioned this pull request Jun 27, 2026

优化鼠标光标 & 添加按钮等悬停效果 #5757

Open

ToobLac added 2 commits June 30, 2026 20:42

Merge remote-tracking branch 'upstream/main' into mod-changelog

e4596a0

# Conflicts: # HMCL/src/main/resources/assets/about/deps.json

update

1f269fc

Minecraft269 reviewed Jul 4, 2026

View reviewed changes

workaround for jei

1729a92

Uh oh!

Conversation

ToobLac commented May 16, 2026

Uh oh!

Minecraft269 left a comment

Choose a reason for hiding this comment

🤖 PR 审查报告 — PR #6098

📊 汇总

✅ 正面发现

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Minecraft269 commented Jun 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Glavo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Minecraft269 commented Jun 26, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

ToobLac Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

Minecraft269 Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

Minecraft269 Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

Minecraft269 left a comment

Choose a reason for hiding this comment

审查：convertToHtml 及关联代码

审查重点

已验证没问题的 Gemini 建议

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

审查：`convertToHtml` 及关联代码