Skip to content

[Enhancement] 启动器检查更新失败时显示提示#6286

Open
ToobLac wants to merge 3 commits into
HMCL-dev:mainfrom
ToobLac:self-veri-fail-tip
Open

[Enhancement] 启动器检查更新失败时显示提示#6286
ToobLac wants to merge 3 commits into
HMCL-dev:mainfrom
ToobLac:self-veri-fail-tip

Conversation

@ToobLac

@ToobLac ToobLac commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
  • 实例无法验证完整性时不尝试更新且显示提示
  • 出现异常时显示检查更新失败提示

@ToobLac ToobLac marked this pull request as ready for review July 1, 2026 10:44
@ToobLac ToobLac changed the title [Enhancement] 启动器实例无法验证完整性时不尝试更新且显示提示 [Enhancement] 启动器检查更新失败时显示提示 Jul 1, 2026
@ToobLac ToobLac marked this pull request as draft July 1, 2026 23:12
@ToobLac ToobLac marked this pull request as ready for review July 2, 2026 08:58
@Minecraft269

Copy link
Copy Markdown

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces error handling for update checks and disables updates if the launcher instance cannot be verified. Specifically, it adds an error property to UpdateChecker to capture update failures, updates SettingsPage to display these errors or hide the update UI if self-verification fails, and adds corresponding localization strings. The review feedback points out a potential issue in UpdateChecker.java where latestVersion could be incorrectly set to null if finalResult is null, as the original null check was omitted in the new error-handling branch, and suggests restoring this check.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/upgrade/UpdateChecker.java
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants