Fix: Fixed truncated authlib injector warning text#6301
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the layout of the AddAuthlibInjectorServerPane by wrapping the server URL text field and the creation warning label inside a VBox body. The review feedback highlights a potential JavaFX layout loop caused by binding the child label's prefWidthProperty to the parent VBox's widthProperty, and suggests setting the label's preferred width to 0 and binding its maxWidthProperty instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ectorServerPane.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the layout of the AddAuthlibInjectorServerPane by wrapping both txtServerUrl and lblCreationWarning inside a VBox body. The review feedback identifies a layout issue where the VBox reserves spacing for the warning label even when its text is empty, resulting in unnecessary blank space. A suggestion is provided to bind the label's visible and managed properties to resolve this.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the layout of the AddAuthlibInjectorServerPane by wrapping the server URL text field and the creation warning label inside a VBox body, updating their layout and visibility bindings accordingly. The reviewer suggests explicitly setting the minimum width of the warning label to 0 to prevent the dialog from expanding unexpectedly when displaying long URLs or exception names.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ectorServerPane.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
修复
AddAuthlibInjectorServerPane中警告信息被截断的问题实况