refactor: delete the server-side rendering paths nothing reaches - #299
Merged
Conversation
This was referenced Aug 30, 2026
Three leftovers from before the reading and review screens moved to client-side rendering: - TextReadingService (333 lines) echoed the reading pane word span by word span. It has no callers; text_renderer.ts took the job over. The only surviving mention was a comment in that file pointing back at it, which now describes the underscore attribute contract on its own terms. - Review's header.php, header_content.php and footer.php are reachable only through ReviewController::header(), and no route registers it. Removing the method takes five tests with it, four of which asserted nothing beyond assertTrue(true) around an include that was expected to fail. - PageLayoutHelper::renderFramesetHeader() has no callers; the app has no framesets left.
HugoFara
force-pushed
the
refactor/remove-dead-server-render
branch
from
August 30, 2026 22:14
8e2f558 to
6d66cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 2 of 6. Base: #298. Deletions only — nothing here has a caller.
Three leftovers from before the reading and review screens moved to client-side
rendering. Net -802 lines.
TextReadingService(333 lines) echoed the reading pane word span by wordspan. No callers anywhere in
src/ortests/;text_renderer.tstook thejob over. The only surviving reference was a comment in that file pointing
back at it, which now describes the underscore attribute contract on its own
terms.
Review/Views/header.php,header_content.php,footer.phparereachable only through
ReviewController::header(), androutes.phpregisters no route for it (only
@index).footer.phphas no includer atall. Removing the method takes five tests with it — four of which asserted
nothing beyond
assertTrue(true)around an include the test itself expectedto fail.
PageLayoutHelper::renderFramesetHeader()— no callers; the app has noframesets left.
To confirm the review views really are unreachable:
grep -n "ReviewController@" src/Shared/Infrastructure/Routing/routes.phpStack: #298 → 2 → #3 → #4 → #5 → #6