fix: expensive sorting of token list. - #218
Merged
Merged
Conversation
Collaborator
|
@thenav56 if you're still around, could you review and merge (to staging)? |
Member
|
Argocd is green. The configmap didn't recreated the stac-auth pod, for now terminated the existing pod to use the latest changes. Applied to both staging and production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every request to the API needs to check "is this person's login token still valid?" To avoid asking that question over and over, the server keeps a cache with up to 50,000 answers.
Once that notebook is full, it needs to erase old answers to make room for new ones. For this, it flips through and re-sort the entire cache just to find the one answer to erase. Every single time.
Instead of "sort everything, then grab the one you need," let's use a heap stack. That should be more performant.