UI 48099: Fix Data Table Select All Row Handling#11779
Open
matheuszych wants to merge 1 commit into
Open
Conversation
See: https://mantis.ilias.de/view.php?id=48099 The "Select all" / "Unselect all" actions in Kitchen Sink data tables only affected the first row and caused a JavaScript exception. Replaced `getElementsByClassName` with `querySelectorAll` in `#disableRowSelection` and `collectSelectedRowIds` so all row selectors are iterated correctly, and rebuilt `table.min.js`.
oliversamoila
added
bugfix
kitchen sink
javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=48099
The "Select all" / "Unselect all" actions in Kitchen Sink data tables only affected the first row and caused a JavaScript exception. Replaced
getElementsByClassNamewithquerySelectorAllin#disableRowSelectionandcollectSelectedRowIdsso all row selectors are iterated correctly, and rebuilttable.min.js./cc @oliversamoila @thibsy @thojou