Conversation
This commit adds `AGENTS.md` to the root of the repository. It includes constraints on Docker and integration tests, as well as mandatory compilation, lint, and unit testing checks using Maven that must pass prior to opening a PR. This helps ensure development within the unprivileged sandboxed environment adheres to the expected CI workflows. Co-authored-by: tuannx <1305700+tuannx@users.noreply.github.com>
…ions using QuickPerf - Integrate quick-perf-junit5 and quick-perf-sql-annotations for test-scoped query verification - Wrap JpaEntityManagerService datasource proxy with QuickPerfSqlDataSourceBuilder - Add DatasetExportQuickPerfIT demonstrating @ExpectMaxSelect assertions and N+1 regression detection
- Add @QuickPerfTest to @JpaPerformanceTest meta-annotation: every perf test now evaluates QuickPerf rules with zero per-test wiring - Add org.quickperf.QuickPerfConfiguration global defaults: N+1 detection, JDBC batching expectation, no connection leaks - Add FileMetadataReadBudgetIT template: max 3 SELECTs budget, 4 seeded files so N+1 becomes 6 SELECTs and fails loudly
ManageGuestbooksPage and the guestbooks API ran up to 4 count queries per guestbook (findCountUsages / findCountByGuestbookId, scoped and global). Add GROUP BY batch methods and read the page/API counts from the resulting maps: 20 SELECTs -> 4 for 5 guestbooks, identical counts. GuestbookCountBudgetIT pins the new-path budget at 4 SELECTs.
Author
|
Closing: created against the wrong repo by mistake, this is a private work-in-progress repro. Will re-open on my fork only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private perf repro, do not merge upstream yet.
Problem
ManageGuestbooksPage and GET /api/dataverses/{id}/guestbooks?stats ran up to 4 count queries per guestbook (findCountUsages / findCountByGuestbookId, each with and without dataverse scope).
Fix
Proof
GuestbookCountBudgetIT: 5 guestbooks over 2 dataverses, uneven spread incl. zero-response + cross-dataverse rows. Legacy path 20 SELECTs, grouped path 4 SELECTs, identical per-guestbook counts. New-path budget pinned at 4.