Fix: Blocked channels accessible via click navigation#72
Open
BaselGamal0 wants to merge 1 commit into
Open
Conversation
Added navigation guards to prevent opening blocked channel pages and playlists from blocked channels. When clicked, a toast message is shown instead. Also added a safety net in ChannelFragment to catch deep links to blocked channels.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
If a user manages to click a blocked channel's icon/name or a playlist from a blocked channel, the app navigates to the channel/playlist page, bypassing the content filter.
Fix
BaseListFragmentthat check if the target channel is blocked. If so, it shows a Toast ("This channel is in your block list") and prevents opening the fragment.ChannelFragment.handleResult()so if a blocked channel page is loaded (e.g. from deep links), it shows the Toast and immediately pops the fragment backstack.channel_is_blockedfor the Toast message.