Skip to content

Fix: Blocked channels still visible in search results #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BaselGamal0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Blocked channels still visible in search results #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions extractor/src/main/java/org/schabi/newpipe/extractor/InfoItemsCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package org.schabi.newpipe.extractor;

import org.schabi.newpipe.extractor.channel.ChannelInfoItem;
import org.schabi.newpipe.extractor.exceptions.FoundAdException;
import org.schabi.newpipe.extractor.exceptions.ParsingException;
import org.schabi.newpipe.extractor.playlist.PlaylistInfoItem;
import org.schabi.newpipe.extractor.stream.StreamInfo;
import org.schabi.newpipe.extractor.stream.StreamInfoItem;

Expand Down Expand Up @@ -175,10 +177,26 @@ public void applyBlocking(FilterConfig filterConfig) {
// Only check channels if we haven't already marked for removal
if (!shouldRemove) {
for (String channel : filterConfig.getChannels()) {
if (item instanceof StreamInfoItem && ((StreamInfoItem) item).getUploaderName() != null &&
((StreamInfoItem) item).getUploaderName().equals(channel)) {
// Filter videos by uploader name
if (item instanceof StreamInfoItem
&& ((StreamInfoItem) item).getUploaderName() != null
&& ((StreamInfoItem) item).getUploaderName().equals(channel)) {
shouldRemove = true;
break; // No need to check other channels
break;
}
// Filter channel search results by channel name
if (item instanceof ChannelInfoItem
&& item.getName() != null
&& item.getName().equals(channel)) {
shouldRemove = true;
break;
}
// Filter playlists by uploader name
if (item instanceof PlaylistInfoItem
&& ((PlaylistInfoItem) item).getUploaderName() != null
&& ((PlaylistInfoItem) item).getUploaderName().equals(channel)) {
shouldRemove = true;
break;
}
}
}
Expand Down