Update randint_untyped to reuse randint implementation - #176
Merged
Merged
Conversation
vlad-perevezentsev
requested review from
antonwolfy,
jharlow-intel,
ndgrigorian and
xaleryb
as code owners
September 17, 2026 13:54
ndgrigorian
previously approved these changes
Sep 24, 2026
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
For the changes only in this PR, this LGTM
ndgrigorian
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
randint_untypedimplementation to reuserandint, addingarray_like(broadcastable)low/highboundslongrange, which used to raiseOverflowErrorfor e.g.randint_untyped(0, 2**40)on WindowsrandintThe generated values and the
int32/int64result type selection are unchanged.It also removes
irk_discrete_uniform_vecandirk_discrete_uniform_long_vec, left without callers by the change above.