Skip to content

fix: ThreadUnsafeCharBlocks#reset using clear without null check - #3607

Open
Timongcraft wants to merge 1 commit into
IntellectualSites:mainfrom
Timongcraft:fix/ThreadUnsafeCharBlocks#reset
Open

fix: ThreadUnsafeCharBlocks#reset using clear without null check#3607
Timongcraft wants to merge 1 commit into
IntellectualSites:mainfrom
Timongcraft:fix/ThreadUnsafeCharBlocks#reset

Conversation

@Timongcraft

Copy link
Copy Markdown
Contributor

Overview

I discovered this while rewriting my logic that captures a paste and prevents a world flush.
This is a minimal fix I can also change it to clear conditionally and mark the maps with MonotonicNonNull or Nullable.
CharSetBlocks's reset also null assigns the biomes etc., which could also be done here.

Description

Replace the map clear calls in ThreadUnsafeCharBlocks with null assignment to allow resetting chunk sets without all kinds of data such as tile entities and entities.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
    - [ ] New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@Timongcraft
Timongcraft requested a review from a team as a code owner August 1, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant