fix: ThreadUnsafeCharBlocks#reset using clear without null check - #3607
Open
Timongcraft wants to merge 1 commit into
Open
fix: ThreadUnsafeCharBlocks#reset using clear without null check#3607Timongcraft wants to merge 1 commit into
Timongcraft wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I discovered this while rewriting my logic that captures a paste and prevents a world flush.
This is a minimal fix I can also change it to clear conditionally and mark the maps with MonotonicNonNull or Nullable.
CharSetBlocks's reset also null assigns the biomes etc., which could also be done here.
Description
Replace the map clear calls in ThreadUnsafeCharBlocks with null assignment to allow resetting chunk sets without all kinds of data such as tile entities and entities.
Submitter Checklist
- [ ] New public fields and methods are annotated with@since TODO.