Skip to content

Fix curves in extended negative world heights - #3608

Open
twme-ai wants to merge 1 commit into
IntellectualSites:mainfrom
twme-ai:fix/issue-3606-negative-y-curve
Open

Fix curves in extended negative world heights#3608
twme-ai wants to merge 1 commit into
IntellectualSites:mainfrom
twme-ai:fix/issue-3606-negative-y-curve

Conversation

@twme-ai

@twme-ai twme-ai commented Aug 1, 2026

Copy link
Copy Markdown

Overview

Fixes #3606

Description

LocalBlockVectorSet.wrapped() is designed to upgrade to BlockVectorSet when a position falls outside its local coordinate range. However, its add(BlockVector3) overload delegated directly to the underlying set and bypassed the upgrade logic in add(int, int, int). EditSession#drawSpline uses the vector overload, causing curves below the vanilla world height to throw an IndexOutOfBoundsException.

This delegates vector additions through the upgrade-aware overload and adds regression coverage for the coordinates reported in the issue, including preservation of entries added before an upgrade.

Testing

  • ./gradlew :worldedit-core:test --tests com.fastasyncworldedit.core.math.LocalBlockVectorSetTest --rerun-tasks --no-daemon --no-configure-on-demand
  • ./gradlew :worldedit-core:build --no-daemon --no-configure-on-demand

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO. No public API was added.
  • I read and followed the contribution guidelines.

@twme-ai
twme-ai requested a review from a team as a code owner August 1, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

//curve fails in extended world heights (Negative Y)

1 participant