Fix curves in extended negative world heights - #3608
Open
twme-ai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3606
Description
LocalBlockVectorSet.wrapped()is designed to upgrade toBlockVectorSetwhen a position falls outside its local coordinate range. However, itsadd(BlockVector3)overload delegated directly to the underlying set and bypassed the upgrade logic inadd(int, int, int).EditSession#drawSplineuses the vector overload, causing curves below the vanilla world height to throw anIndexOutOfBoundsException.This delegates vector additions through the upgrade-aware overload and adds regression coverage for the coordinates reported in the issue, including preservation of entries added before an upgrade.
Testing
./gradlew :worldedit-core:test --tests com.fastasyncworldedit.core.math.LocalBlockVectorSetTest --rerun-tasks --no-daemon --no-configure-on-demand./gradlew :worldedit-core:build --no-daemon --no-configure-on-demandSubmitter Checklist
@since TODO. No public API was added.