Skip to content

test: cover programmatic wildcard exclusion transformers #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 2 commits into from
Sep 24, 2026
+62 −0
Merged

test: cover programmatic wildcard exclusion transformers #2652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f929d2
fix: default wildcard exclusions to EXCEPT
jakezwang Sep 19, 2026
20793d4
Adapt wildcard exclusion tests to column transformers
jakezwang Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions src/test/java/net/sf/jsqlparser/statement/select/AllColumnsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,17 @@
*/
package net.sf.jsqlparser.statement.select;

import static net.sf.jsqlparser.test.TestUtils.assertDeparse;
import static net.sf.jsqlparser.test.TestUtils.assertSqlCanBeParsedAndDeparsed;
import static org.junit.jupiter.api.Assertions.assertEquals;

import net.sf.jsqlparser.JSQLParserException;
import net.sf.jsqlparser.expression.ColumnsTransformer;
import net.sf.jsqlparser.expression.ColumnsTransformer.ColumnsTransformerType;
import net.sf.jsqlparser.expression.operators.relational.ParenthesedExpressionList;
import net.sf.jsqlparser.parser.CCJSqlParserUtil;
import net.sf.jsqlparser.schema.Column;
import net.sf.jsqlparser.schema.Table;
import net.sf.jsqlparser.test.TestUtils;
import org.junit.jupiter.api.Test;

Expand All @@ -31,4 +41,56 @@ void testDuckDBQuerySyntax() throws JSQLParserException {
+ "FROM orders";
TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
}

@Test
void addExceptColumnToNewWildcard() throws JSQLParserException {
AllColumns columns = new AllColumns();
columns.addTransformer(new ColumnsTransformer(ColumnsTransformerType.EXCEPT)
.setExceptColumns(new ParenthesedExpressionList<>(new Column("hidden"))));
PlainSelect select = new PlainSelect().addSelectItem(columns).withFromItem(new Table("t"));

String expected = "SELECT * EXCEPT (hidden) FROM t";
assertEquals(expected, select.toString());
assertDeparse(select, expected);
assertSqlCanBeParsedAndDeparsed(expected);
}

@Test
void setExceptColumnsOnParsedWildcard() throws JSQLParserException {
PlainSelect select = (PlainSelect) CCJSqlParserUtil.parse("SELECT * FROM t");
AllColumns columns = select.getSelectItem(0).getExpression(AllColumns.class);
columns.addTransformer(new ColumnsTransformer(ColumnsTransformerType.EXCEPT)
.setExceptColumns(new ParenthesedExpressionList<>(new Column("hidden"))));

String expected = "SELECT * EXCEPT (hidden) FROM t";
assertEquals(expected, select.toString());
assertDeparse(select, expected);
assertSqlCanBeParsedAndDeparsed(expected);
}

@Test
void addExceptColumnToParsedTableWildcard() throws JSQLParserException {
PlainSelect select = (PlainSelect) CCJSqlParserUtil.parse("SELECT t.* FROM t");
AllTableColumns columns = select.getSelectItem(0).getExpression(AllTableColumns.class);
columns.addTransformer(new ColumnsTransformer(ColumnsTransformerType.EXCEPT)
.setExceptColumns(new ParenthesedExpressionList<>(new Column("hidden"))));

String expected = "SELECT t.* EXCEPT (hidden) FROM t";
assertEquals(expected, select.toString());
assertDeparse(select, expected);
assertSqlCanBeParsedAndDeparsed(expected);
}

@Test
void preserveExplicitExcludeTransformer() throws JSQLParserException {
AllColumns columns = new AllColumns();
columns.addTransformer(new ColumnsTransformer(ColumnsTransformerType.EXCLUDE)
.setExceptColumns(new ParenthesedExpressionList<>(new Column("hidden"))));
PlainSelect select = new PlainSelect().addSelectItem(columns).withFromItem(new Table("t"));

String expected = "SELECT * EXCLUDE (hidden) FROM t";
assertEquals(expected, select.toString());
assertDeparse(select, expected);
assertSqlCanBeParsedAndDeparsed(expected);
}
}
Loading