[Fix] 공고 분석 필수 필드 검증 범위 조정#175
Conversation
- 공고 분석 품질 검증 대상을 공고명, 회사명, 직무로 제한 - 주요 업무와 자격 요건은 분석 실패 기준에서 제외 - 공고 분석 실패 시 invalid field 목록을 응답 error payload로 반환 - GeneralException에 구조화된 error payload 전달 기능 추가 - 공고 분석 검증 정책 변경에 맞춰 테스트 수정 및 추가
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthrough채용 공고 입력 검증이 필수 필드별 오류 정보를 수집하도록 변경되었습니다. 상세 오류 DTO와 예외 전달 구조가 추가되었고, 추출·생성 결과 및 관련 테스트가 새 응답 형식에 맞게 갱신되었습니다. Changes채용 공고 입력 검증
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant IngestService
participant JobPostingIngestQualityValidator
participant GeneralException
participant ExceptionAdvice
IngestService->>JobPostingIngestQualityValidator: 추출·생성 결과 검증
JobPostingIngestQualityValidator->>GeneralException: 무효 필드 목록 포함 예외 생성
GeneralException->>ExceptionAdvice: error 데이터 전달
ExceptionAdvice-->>IngestService: 상세 실패 응답 반환
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/jobdri/jobdri_api/domain/jobposting/service/JobPostingIngestQualityValidator.java`:
- Around line 64-68: Update the required-field validation in
JobPostingIngestQualityValidator to pass generated.postingName() for the
postingName field instead of generated.jobTitle(). Ensure postingName remains a
distinct value from jobTitle through the generation response and save request
flow, and update related tests so an invalid jobTitle is not also reported as an
invalid postingName.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3b8113aa-dd5d-403a-af17-6d129e0315cf
📒 Files selected for processing (6)
src/main/java/com/jobdri/jobdri_api/domain/jobposting/dto/response/JobPostingIngestValidationErrorResponse.javasrc/main/java/com/jobdri/jobdri_api/domain/jobposting/service/JobPostingIngestQualityValidator.javasrc/main/java/com/jobdri/jobdri_api/global/apiPayload/exception/GeneralException.javasrc/main/java/com/jobdri/jobdri_api/global/apiPayload/exception/handler/ExceptionAdvice.javasrc/test/java/com/jobdri/jobdri_api/domain/jobposting/service/JobPostingIngestServiceTest.javasrc/test/java/com/jobdri/jobdri_api/domain/jobposting/service/JobPostingWorkerBridgeServiceTest.java
- JobPostingGenerateResponse에 postingName 필드 추가 - 공고 생성 프롬프트 응답 스키마에 postingName 포함 - 공고 저장 시 postingName과 jobTitle을 각각 별도 필드로 매핑 - 공고명 검증이 jobTitle이 아닌 postingName을 기준으로 동작하도록 수정 - invalid jobTitle이 postingName invalid로 함께 보고되지 않도록 테스트 추가
1 participant
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [ ]
Summary by CodeRabbit
개선 사항
테스트