More KernelInterface interface tests - #746
Open
christiangnrd wants to merge 3 commits into
Open
Conversation
christiangnrd
force-pushed
the
typetests
branch
from
August 27, 2026 17:09
fdfae04 to
c3de0b7
Compare
Contributor
Benchmark ResultsShow table
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
christiangnrd
force-pushed
the
typetests
branch
6 times, most recently
from
September 3, 2026 14:12
ceef27c to
10be9c2
Compare
vchuravy
reviewed
Sep 3, 2026
|
|
||
| # The interface documents a concrete return type for each device-side function; | ||
| # these kernels record whether the backend honors them. | ||
| const WorkItemNT = @NamedTuple{x::Int, y::Int, z::Int} |
Member
There was a problem hiding this comment.
Should we define this alias in the package?
Member
Author
There was a problem hiding this comment.
Maybe? However I was starting to think that we should maybe have the get_X_size and get_X_id intrinsics take an optional type so people can have their kernels use 4-byte indexingwhen they know they won't need more and it might be annoying to do after we've defined this
christiangnrd
force-pushed
the
typetests
branch
2 times, most recently
from
September 3, 2026 17:50
dff88e2 to
715e8fb
Compare
christiangnrd
force-pushed
the
typetests
branch
from
September 6, 2026 00:13
715e8fb to
73fdef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.