Apply β in generic_matmatmul!/generic_matvecmul! when the inner dimension is empty. - #628
Merged
Conversation
…sion is empty The empty-operand shortcuts unconditionally zeroed the output, but for K == 0 the result is β*C (as LinearAlgebra's _rmul_or_fill! does). Also clamp the preliminary workgroup size in launch_config to at least 1, so launching a kernel over an empty ndrange (e.g. rmul! on a 0×N array) takes the groups == 0 early return instead of throwing a DivideError. Uncovered by the K == 0 tests added in JuliaGPU/GPUArrays.jl#773. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 79.52% 81.19% +1.66%
==========================================
Files 50 50
Lines 3571 3568 -3
==========================================
+ Hits 2840 2897 +57
+ Misses 731 671 -60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The empty-operand shortcuts unconditionally zeroed the output, but for K == 0 the result is β*C (as LinearAlgebra's _rmul_or_fill! does).
Also clamp the preliminary workgroup size in launch_config to at least 1, so launching a kernel over an empty ndrange (e.g. rmul! on a 0×N array) takes the groups == 0 early return instead of throwing a DivideError.
Uncovered by the K == 0 tests added in JuliaGPU/GPUArrays.jl#773.