Add GNNGraphsEnzymeCoreExt marking scaled_laplacian inactive for Enzyme - #706
Open
Parvm1102 wants to merge 1 commit into
Open
Add GNNGraphsEnzymeCoreExt marking scaled_laplacian inactive for Enzyme#706Parvm1102 wants to merge 1 commit into
Parvm1102 wants to merge 1 commit into
Conversation
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
Contributor
Author
|
Please review this @CarloLucibello |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scaled_laplacianis already@non_differentiablefor ChainRules, but Enzyme does notread those declarations, so it differentiated the Krylov eigensolve inside it and failed
with an
IllegalTypeAnalysisExceptionin SparseArrays. The Laplacian depends only on thegraph, never on the node features, so treating it as constant loses no gradient.
This adds a small
EnzymeCorepackage extension (same pattern as the Mooncake extension)with a single
EnzymeRules.inactivedeclaration, plus a test.Unblocks
ChebConv,GConvGRUCellandGConvLSTMCellunder Enzyme;GConvGRU/GConvLSTMadditionally need a separate
GNNRecurrencefix.