Slice GNNRecurrence input by indexing instead of eachslice views - #707
Merged
CarloLucibello merged 2 commits intoAug 26, 2026
Merged
Conversation
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enzyme's type analysis fails when a recurrent cell receives a
SubArrayview of the3-d input (
DCGRUCellon a plain matrix passes; the same cell insideGNNRecurrencefails). Indexing the time slice instead of using
eachslicefixes this and matcheshow the Lux frontend already slices. The copy is one
features × nodesslice per step.Verified under Enzyme:
DCGRU,EvolveGCNO,GConvGRUandGConvLSTMnow matchZygote (the latter two also need #706). Zygote/Mooncake temporal tests: 60/60.
Note:
TGCNremains unsupported under Enzyme — with the view failure gone it runs intoTGCNCell's known compile hang, so it must stay excluded from Enzyme test runs.