Skip attention dropout in GATConv/GATv2Conv when dropout == 0 - #709
Open
Parvm1102 wants to merge 1 commit into
Open
Skip attention dropout in GATConv/GATv2Conv when dropout == 0#709Parvm1102 wants to merge 1 commit into
Parvm1102 wants to merge 1 commit into
Conversation
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
Contributor
Author
|
@CarloLucibello please review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NNlib.dropout(A, p) fetches the RNG (CUDA.default_rng() for CuArray) before it checks p, so dropout = 0 still pulls the CUDA RNG into the traced program, which Mooncake cannot differentiate. Every GATConv/GATv2Conv gradient on the GPU failed under Mooncake (#702).
MWE:
TypeError: in typeassert, expected CoDual{IdDict{Any,Any}, IdDict{Any,Any}}, got CoDual{IdDict{Any,Any}, NoFData}Fix: skip the dropout call when p == 0 in gat_conv/gatv2_conv (also saves an RNG launch at inference). With it, GATConv and GATv2Conv pass all 96 GPU gradient sites under Mooncake (≤ 2.5e-7 vs Zygote); CPU tests unchanged. dropout > 0 still needs an upstream Mooncake rule for CUDA.default_rng(), tracked in #702.