fix(cloud-agent): wire Code Reviewer sandbox cleanup#4292
Open
eshurakov wants to merge 1 commit into
Open
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| const policy = resolveEphemeralSandboxPolicy(this.env, metadata); | ||
| if (!policy.enabled) return; | ||
| if (!isCodeReviewEphemeralSandboxId(metadata.workspace?.sandboxId)) return; | ||
| await this.getWrapperSupervisor().requestPhysicalWrapperStop('terminal-completed', { |
Contributor
There was a problem hiding this comment.
WARNING: Cleanup also runs after failed and interrupted terminal events
handleWrapperTerminalEvent() schedules the Code Reviewer wrapper stop and delayed sandbox destruction for every terminal event once the session is on a crv-* sandbox, because this new block never checks params.status. That means failed and interrupted runs will also be torn down 60 seconds later, removing the retry/debug window that the supervisor still preserves for unsuccessful runs and conflicting with the PR's stated "after normal completions" intent.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Fix these issues in Kilo Cloud Files Reviewed (25 files)
Reviewed by gpt-5.4-20260305 · Input: 104K · Output: 15.5K · Cached: 1.1M Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crv-*sandboxes, including status reporting and alarm-driven destruction.crv-*so rollout allowlist changes do not tear down shared sandboxes.Verification
N/A - backend lifecycle change with no manual UI path.
Visual Changes
N/A
Reviewer Notes
Focus on the terminal-event lifecycle wiring and the route-based
crv-*cleanup guard. The guard intentionally uses the allocated sandbox ID in addition to current org policy so rollout config changes cannot make older shared allocations destructible.