InterfaceRef<T> improvements - #42
Open
BitterSmile wants to merge 2 commits into
Open
BitterSmile wants to merge 2 commits into
BitterSmile wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for this package, I've been using it for a few years in every project!
I've made 2 changes to improve work with InterfaceRef
Firstly, there is new override for Equals. It is added to avoid marking scenes as dirty when it is not needed. Right now in SceneRefAttributeValidator there is
so it will always set valueIsEqual to false for InterfaceRef as a new instance of it was created few lines before.
Another change is to handle drag and drop and get proper value. I encountered that problem few times personaly and I see that it was also reported here: #40
It is quite straight forward change