FW trigpath block refactor - #459
Merged
Merged
Conversation
we only want the OptoLink's coder_ to change, the Transport's coder_ should still point at the DAQ's firmware area since that is where the slow control downlink stuff is
tomeichlersmith
commented
Aug 17, 2026
Member
Author
|
Notes about software changes from firmware cleanup...
|
- access name of UIO device from UIO object - use same suffix for trigpath as input coder_name to ZCUOptoLink - name magic register numbers in variables - cleanup status and rates printout to make data/trig output similar - document change in coder name but not transport - check on FW version to remind folks to update FW
tomeichlersmith
force-pushed
the
fw-trigpath-refactor
branch
from
August 21, 2026 14:09
95ce0a8 to
6bdf603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to prepare the trigger path firmware for translating it onto the APx, I moved the lpGBT decoding from the
standardLpGBTPairblock into thetrigpathblock. On the software side, this affects which registers theZCUOptoLinkshould look at when it is trying to check on the status and rates of the trigger fiber (as opposed to the DAQ fiber).Leaving this as a draft since I want to clean up the code more and get a nice version of the firmware built that I can post somewhere for others to download and use.