Disallow mutating SQL in GET requests#7791
Merged
Merged
Conversation
labkey-jeckels
approved these changes
Jun 24, 2026
labkey-adam
added a commit
that referenced
this pull request
Jun 26, 2026
## Rationale Optional feature check was causing reentrancy on bootstrap ## Related Pull Requests - #7791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
For a long time (since 2019?) we've prohibited mutating SQL (
INSERT,UPDATE,DELETE, etc.) via GET requests when running in dev mode with asserts on. It's past time to turn this on for production-mode deployments. This protects our customers from Cross-Site Request Forgery (CSRF) attacks. A deprecated feature flag can be enabled to turns this off temporarily in case a customer discovers a mutating action that isn't hasn't been migrated to POST. https://github.com/LabKey/kanban/issues/1941Related Pull Requests
User Education
Tasks 📍