Skip to content

Exercise big ints in RlabkeyTest#3012

Closed
bbimber wants to merge 2 commits into
release26.3-SNAPSHOTfrom
26.3_fb_bigint
Closed

Exercise big ints in RlabkeyTest#3012
bbimber wants to merge 2 commits into
release26.3-SNAPSHOTfrom
26.3_fb_bigint

Conversation

@bbimber

@bbimber bbimber commented May 21, 2026

Copy link
Copy Markdown
Collaborator

This is related to this PR:

LabKey/labkey-api-r#126

which is designed to make Rlabkey support big int values.

Comment thread data/lists/rlabkey.lists/AllTypes.tsv
</column>
<column columnName="IntFld">
<datatype>integer</datatype>
<datatype>bigint</datatype>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get the Rlabkey test passing now with this change, I needed to update line 261 of rlabkey-api-query.xml to:
HTTP request was unsuccessful. Status code = 400, Error message = Could not convert value 'string' (String) for Long field 'IntFld'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will get this running locally and look into this. I want to understand what triggered the change.

I have noticed that something in either the Rlabkey side or the server side converts columns that are 100% NA (not a string), into the string 'NA'. I have long wondered whether this is a bug in Rlabkey. This change might be exposing that here.

@cnathe

cnathe commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

I think this new test case can just go to develop instead of 26.3 at this point in the release cycle. I'll open a new PR with these changes targeting develop since I have to create a new PR for the labkey-api-r version bump anyway.

@cnathe

cnathe commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

#3078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants