Add WNPRC_EHRTest for Time of Day lovcombo multi-select#982
Merged
labkey-martyp merged 5 commits intoJun 29, 2026
Conversation
Adds testTreatmentTimeOfDayMultiSelect: opens the Treatments task Import Scheduled Treatments dialog, selects multiple Time of Day values in the string-valued lovcombo, and submits. It asserts the selection is retained and reaches the schedule query (alert 'No uncompleted treatments were found.') rather than the pre-fix validation alert 'Must provide room and time of day'. Exercises the LovCombo fix end-to-end. LabKey/internal-issues#1266
…fb_lovcombo_timeofday_1266
labkey-bpatel
approved these changes
Jun 29, 2026
…fb_lovcombo_timeofday_1266
labkey-martyp
added a commit
to LabKey/platform
that referenced
this pull request
Jun 29, 2026
…7796) ## Rationale Newer browsers (Chrome, Firefox 140+) ship a native `RegExp.escape` that throws a `TypeError` on non-String input. `Ext.ux.form.LovCombo.setValue()` passed `JSON.stringify(value)` to `RegExp.escape` to avoid that crash, but `JSON.stringify()` quotes string values, so they no longer matched the raw, unquoted output of `getCheckedValue()` and every selection in a string-valued combo (e.g. the WNPRC EHR Time of Day multi-select) was silently dropped. Using `String()` yields a valid String for `RegExp.escape` without quoting string values, fixing both the numeric-`valueField` crash and the string-`valueField` regression. See LabKey/internal-issues#1266. ## Related Pull Requests - LabKey/wnprc-modules#982 - LabKey/premiumModules#638 ## Changes - `core/webapp/Ext.ux.form.LovCombo.js`: in `setValue()`, pass `String(...)` rather than `JSON.stringify(...)` to `RegExp.escape`.
labkey-martyp
commented
Jun 29, 2026
labkey-martyp
left a comment
labkey-martyp
left a comment
Contributor
Author
There was a problem hiding this comment.
Tests pass locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Adds end-to-end test coverage for the LovCombo fix in https://github.com/LabKey/internal-issues/issues/1266. The "Time of Day" multi-select on the Treatments task's Import Scheduled Treatments dialog is a string-valued
lovcombo; before the fix its selections were silently dropped and Submit failed validation with "Must provide room and time of day".Related Pull Requests
Changes
WNPRC_EHR/test/src/org/labkey/test/tests/wnprc_ehr/WNPRC_EHRTest.java: addtestTreatmentTimeOfDayMultiSelect, which opens the dialog, selects multiple Time of Day values, asserts the selection is retained, and submits — expecting the "No uncompleted treatments were found." alert rather than the pre-fix "Must provide room and time of day" validation alert.