feat(client): fetch contract ABIs from Sourcify, fall back to Etherscan - #309
Open
manuelwedler wants to merge 1 commit into
Open
feat(client): fetch contract ABIs from Sourcify, fall back to Etherscan#309manuelwedler wants to merge 1 commit into
manuelwedler wants to merge 1 commit into
Conversation
Sourcify is now tried first when fetching a reference ABI, and Etherscan is only used when Sourcify has nothing for the contract. Sourcify needs no API key, so ABI validation and descriptor generation now work out of the box, including on chains Etherscan does not cover. Sourcify returning 404 (contract not verified) or 400 (chain not supported) falls through to Etherscan. If both sources fail, the raised error names both causes, and linters keep skipping ABI validation with a "Could not fetch ABI" warning as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could not fetch ABIwarning.