Fastchess upgrade and error report improvements - #11
Open
Menkib64 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the Fastchess integration to a newer upstream and improves client-side error reporting so the server receives more useful diagnostics (including time-loss reports and longer engine log context).
Changes:
- Bump required Fastchess version and switch the configured Fastchess repository URL.
- Increase the number of engine log lines attached to error reports.
- Fix the GPU-crash benchmark check to match the updated
safe_run_benchmarkscall signature and add time-forfeit classification in PGN termination parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Config/config.json | Updates minimum Fastchess version and points to the new Fastchess upstream repo. |
| Client/worker.py | Expands error-report log context, fixes benchmark call signature for GPU-crash checking, and adds time-forfeit error classification. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new Fastchess version ignores SIGPIPE which was causing termination if engine crashed. Error reporting will add reports for time losses, increase log history length to include more relevant information before a problem, and fix gpu problem checking using outdated function call signature.