Improve cppo usage - #105
Open
fantazio wants to merge 2 commits into
Open
Conversation
Gather most of the uses in Utils.Compat, in dedicated functions (either conversions or getters). Sort the branches in version descending order. If the conditional branches are close enough, do not repeat the bounds. If the #else stands out enough, do not convert it into #elif. If all the versions should be accounted without #else, add an #else that throws an #error.
Instead of systematically returning an option, they now return a result, and a dedicated error gadt `'a invalid_arg` is introduced. In addition, getters have a `*_exn` variant to directly unwrap the result when the argument is already known to have the right shape.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gather most of the uses in
Utils.Compat, in dedicated functions (either conversions or getters).Sort the branches in version descending order.
Iff the conditional branches are close enough, do not repeat the bounds, and iff the #else is close enough the the previous condition, do not convert it into #elif.
If all the versions are accounted without #else, add an #else that throws an #error.