Write generated files with LF line endings - #91
Merged
Merged
Conversation
The T4 templates emit CRLF in their literal text while SummarySafe uses Environment.NewLine for doc comments, so on Linux and macOS generated files came out with mixed line endings. Normalizing on write also keeps output identical across platforms, so teams with both Windows and Linux developers no longer see the whole client as modified after each run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The T4 templates emit CRLF in their literal text while
SummarySafeusesEnvironment.NewLinefor doc comments, so on Linux and macOS generated files came out with mixed line endings.Normalizing on write also makes output identical across platforms, so teams with both Windows and Linux developers no longer see the whole generated client reported as modified after each run.