Skip to content

Add proper parameters - #12

Merged
ildyria merged 2 commits into
mainfrom
more-secure
Jul 18, 2026
Merged

Add proper parameters#12
ildyria merged 2 commits into
mainfrom
more-secure

Conversation

@ildyria

@ildyria ildyria commented Jul 18, 2026

Copy link
Copy Markdown
Member

This pull request introduces improvements for handling sensitive parameter values, updates dependencies, and makes minor code style adjustments. The most significant changes are the adoption of the SensitiveParameterValue wrapper for sensitive data, enhancements to static analysis tooling, and dependency reordering.

Sensitive parameter handling:

  • Refactored Verify class to store config_email and license_key as SensitiveParameterValue objects instead of plain strings, and updated all usages to call .getValue() when accessing the underlying value. This ensures sensitive values are handled securely throughout the codebase. [1] [2] [3] [4]
  • Updated TestVerifyFactory and related test code to use SensitiveParameterValue for sensitive parameters, improving test coverage for sensitive value handling. [1] [2]

Static analysis and dev tooling:

  • Added lychee-org/phpstan-sensitive-parameter-values as a dev dependency and included its extension in phpstan.neon for improved static analysis of sensitive parameters. [1] [2]

Dependency management:

  • Reordered and grouped dev dependencies in composer.json for clarity and maintainability.

Code style and consistency:

  • Updated several constructors to use explicit curly braces for improved readability and consistency. [1] [2] [3]

Miscellaneous:

  • Updated the hash for Verify::class in config/verify.php to reflect code changes.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ildyria, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 78a7f749-9ad2-4a12-a9f7-0f359dac4c14

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb6316 and 867f55d.

📒 Files selected for processing (13)
  • composer.json
  • config/verify.php
  • phpstan.neon
  • src/Contract/RotationResult.php
  • src/Contract/TokenExtensionResult.php
  • src/Contract/ValidatorInterface.php
  • src/Rotation.php
  • src/Validators/ValidatePro.php
  • src/Validators/ValidateSignature.php
  • src/Validators/ValidateSupporter.php
  • src/Verify.php
  • tests/TestVerifyFactory.php
  • tests/Verify/RotationTest.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ildyria
ildyria merged commit 4d50f55 into main Jul 18, 2026
18 checks passed
@ildyria
ildyria deleted the more-secure branch July 18, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant