Implementation of from_alphafold - #5457
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5457 +/- ##
===========================================
+ Coverage 93.87% 93.88% +0.01%
===========================================
Files 182 183 +1
Lines 22510 22651 +141
Branches 3202 3228 +26
===========================================
+ Hits 21131 21267 +136
- Misses 917 921 +4
- Partials 462 463 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Docs are also done here |
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Impressive work, nice!
My comments are mostly docs and coding style.
I'll leave the heavy commenting to @BradyAJohnston @yuxuanzhuang @talagayev .
There was a problem hiding this comment.
Is this PR introducing StaticFetcher ?
There was a problem hiding this comment.
Now I am seeing that the main PR is really #5436 – I'll add a quick comment there to send you back here. Sorry.
| This suite of functions download structure files from the Research | ||
| Collaboratory for Structural Bioinformatics (RCSB) | ||
| `Protein Data Batabank`_ (PDB). |
There was a problem hiding this comment.
The header only talks about Protein Databank but the AlphaFold fetcher is also in here. Personally, I'd create a separate module for AlphaFold, similar to this one here.
However, if you and your mentors prefer to have it in the same file then please at least update the text here to also talk about the AF database (with link).
|
Just saw comment here. Will spend time this weekend to address this |
b6fa123 to
be564e7
Compare
be564e7 to
c0c525c
Compare
5 participants
Fixes #5432
Changes made in this Pull Request:
from_alphafoldusingStaticFetcherLLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.