Skip to content

chore: exclude SVG files from Biome checks#11923

Closed
sileht wants to merge 2 commits into
devs/sileht/dependabot/npm_and_yarn/biomejs/biome-2.5.0/bump-biomejs-biome-2-4-16-2-5-0--bafad658from
devs/sileht/dependabot/npm_and_yarn/biomejs/biome-2.5.0/exclude-svg-files-biome-checks--618ea78c
Closed

chore: exclude SVG files from Biome checks#11923
sileht wants to merge 2 commits into
devs/sileht/dependabot/npm_and_yarn/biomejs/biome-2.5.0/bump-biomejs-biome-2-4-16-2-5-0--bafad658from
devs/sileht/dependabot/npm_and_yarn/biomejs/biome-2.5.0/exclude-svg-files-biome-checks--618ea78c

Conversation

@sileht

@sileht sileht commented Jun 24, 2026

Copy link
Copy Markdown
Member

Biome 2.5.0 added HTML/SVG parsing, which fails on the repo's SVG assets
(unescaped '<' and a non-UTF-8 stream). Exclude *.svg from the Biome file
set so 'biome check' passes with the bumped version.

Depends-On: #11922

dependabot Bot and others added 2 commits June 24, 2026 13:47
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.4.16 to 2.5.0.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.0/packages/@biomejs/biome)

Change-Id: I1401d082889c155cabae0d09791238afb988be99

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.5.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Change-Id: Ibafad658f2554fef50fc08ee37e43866f751e9a0
Biome 2.5.0 added HTML/SVG parsing, which fails on the repo's SVG assets
(unescaped '<' and a non-UTF-8 stream). Exclude *.svg from the Biome file
set so 'biome check' passes with the bumped version.

Change-Id: I618ea78c0b685be653dbf583a28be5164df406a8
@sileht

sileht commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 chore(deps-dev): bump @biomejs/biome from 2.4.16 to 2.5.0 #11922
2 chore: exclude SVG files from Biome checks #11923 👈

@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 24, 2026 11:47 Failure
@mergify

mergify Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 3 of 7 protections blocking · waiting on 👀 reviews and 🙋 you

Protection Waiting on
🔴 ⛓️ Depends-On Requirements 🙋 you
🔴 👀 Review Requirements 👀 reviews
🔴 🔎 Reviews 👀 reviews
🟢 🤖 Continuous Integration
🟢 Enforce conventional commit
🟢 📕 PR description
🟢 🚦 Auto-queue

🔴 ⛓️ Depends-On Requirements

Waiting for

This rule is failing.

Requirement based on the presence of Depends-On in the body of the pull request

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by >= 2
This rule is failing.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

Show 4 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify mergify Bot requested a review from a team June 24, 2026 11:50
@sileht sileht marked this pull request as ready for review June 24, 2026 11:52
@sileht sileht force-pushed the devs/sileht/dependabot/npm_and_yarn/biomejs/biome-2.5.0/bump-biomejs-biome-2-4-16-2-5-0--bafad658 branch from b7a59a9 to 5c4ad27 Compare June 24, 2026 11:55
@sileht sileht closed this Jun 24, 2026
@sileht sileht deleted the devs/sileht/dependabot/npm_and_yarn/biomejs/biome-2.5.0/exclude-svg-files-biome-checks--618ea78c branch June 24, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant