feat: add originMetadata to submitRequest - #615
Merged
Conversation
originMetadata to submitRequestoriginMetadata to submitRequest
FrederikBolding
marked this pull request as ready for review
August 6, 2026 14:47
FrederikBolding
force-pushed
the
fb/add-origin-metadata
branch
from
August 7, 2026 08:23
c080046 to
6556609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
originMetadatafield tosubmitRequest, which will be passed along in keyrings that are using at least platform version12. This field can be used when using transports where theoriginitself isn't verifiable.https://consensyssoftware.atlassian.net/browse/WPC-1195
Note
Medium Risk
Touches signing request routing and origin attribution across v1/v2 Snap keyrings; incorrect version gating could omit or leak metadata to incompatible Snaps, but behavior is covered by platform-version checks and tests.
Overview
Adds optional
originMetadataon keyringsubmitRequest/KeyringRequest, withtransportandselfReportedOrigin, so Snaps can reason about callers when the plainoriginis not trustworthy (e.g. WalletConnect).SnapKeyringandSnapKeyringV1acceptoriginMetadataand forward it only when the Snap platform is ≥ 12.0.0; older platforms getoriginonly (7.0.0–11.x) or neither field (< 7.0.0), via newtoKeyringRequestWithoutOriginMetadata,submitRequestWithoutOriginMetadata, and updatedtoKeyringRequestWithoutOrigin(also stripsoriginMetadata).EthKeyringV1Adapteralways sendsoriginMetadata: nullon internal submits.Coverage is extended across bridge, internal API, snap client, and v2
SnapKeyringpaths.Reviewed by Cursor Bugbot for commit 8f3bfe8. Bugbot is set up for automated code reviews on this repo. Configure here.