Skip to content

chore: disable persistence for legacy assets controllers - #9842

Open
salimtb wants to merge 2 commits into
mainfrom
chore/disable-persist-legacy-assets-controllers
Open

chore: disable persistence for legacy assets controllers#9842
salimtb wants to merge 2 commits into
mainfrom
chore/disable-persist-legacy-assets-controllers

Conversation

@salimtb

@salimtb salimtb commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Stop writing Tokens, CurrencyRate, TokenRates, TokenBalances, AccountTracker, and Multichain assets/rates/balances controller state to disk so clients can rely on AssetsController instead.

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes what asset-related state is written to disk, including user token lists and ignored assets. Clients that still depend on these controllers for persistence may lose that state on restart if they have not migrated.

Overview
Stops writing legacy assets controller state to disk so clients can rely on AssetsController instead.

Sets persist: false on state metadata for TokensController, CurrencyRateController, TokenRatesController, TokenBalancesController, AccountTrackerController, MultichainAssetsController, MultichainAssetsRatesController, and MultichainBalancesController. Persistence tests now expect empty persisted state.

Reviewed by Cursor Bugbot for commit f5efcc8. Bugbot is set up for automated code reviews on this repo. Configure here.

Stop writing Tokens, CurrencyRate, TokenRates, TokenBalances,
AccountTracker, and Multichain assets/rates/balances controller
state to disk so clients can rely on AssetsController instead.
@salimtb
salimtb marked this pull request as ready for review August 12, 2026 13:58
@salimtb
salimtb requested review from a team as code owners August 12, 2026 13:58
@salimtb
salimtb deployed to default-branch August 12, 2026 13:59 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant