chore: disable persistence for legacy assets controllers - #9842
Open
salimtb wants to merge 2 commits into
Open
Conversation
Stop writing Tokens, CurrencyRate, TokenRates, TokenBalances, AccountTracker, and Multichain assets/rates/balances controller state to disk so clients can rely on AssetsController instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop writing Tokens, CurrencyRate, TokenRates, TokenBalances, AccountTracker, and Multichain assets/rates/balances controller state to disk so clients can rely on AssetsController instead.
Explanation
References
Checklist
Note
Medium Risk
Changes what asset-related state is written to disk, including user token lists and ignored assets. Clients that still depend on these controllers for persistence may lose that state on restart if they have not migrated.
Overview
Stops writing legacy assets controller state to disk so clients can rely on
AssetsControllerinstead.Sets
persist: falseon state metadata forTokensController,CurrencyRateController,TokenRatesController,TokenBalancesController,AccountTrackerController,MultichainAssetsController,MultichainAssetsRatesController, andMultichainBalancesController. Persistence tests now expect empty persisted state.Reviewed by Cursor Bugbot for commit f5efcc8. Bugbot is set up for automated code reviews on this repo. Configure here.