Security: Unsafe YAML Loading in postprocess_toc_yml.py#2058
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The code uses yaml.load() without specifying a Loader parameter, which defaults to the unsafe Loader. This can lead to arbitrary code execution if an attacker can control the contents of toc.yml. The yaml.load() function is known to be vulnerable to deserialization attacks when used without a safe loader. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Contributor
|
Learn Build status updates of commit 7e2f788: ✅ Validation status: passed
For more details, please refer to the build report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unsafe YAML Loading in postprocess_toc_yml.py
Problem
Severity:
Critical| File:ci_scripts/postprocess_toc_yml.py:L28The code uses yaml.load() without specifying a Loader parameter, which defaults to the unsafe Loader. This can lead to arbitrary code execution if an attacker can control the contents of toc.yml. The yaml.load() function is known to be vulnerable to deserialization attacks when used without a safe loader.
Solution
Use yaml.safe_load() instead of yaml.load(), or explicitly pass Loader=yaml.SafeLoader to yaml.load(). For example: data_loaded = yaml.safe_load(stream) or data_loaded = yaml.load(stream, Loader=yaml.SafeLoader)
Changes
ci_scripts/postprocess_toc_yml.py(modified)