feat(l10n): add Korean localization - #6506
Conversation
fdebe65 to
b8d9fd6
Compare
There was a problem hiding this comment.
Pull request overview
Enables Korean localization across app packaging, locale selection, and identity verification, while expanding several existing translation catalogs.
Changes:
- Registers and packages the Korean locale.
- Adds Korean to legacy and Compose language selectors.
- Adds or completes localized strings and arrays for supported languages.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
app/build.gradle.kts |
Packages Korean resources. |
app/src/main/java/one/mixin/android/Constants.kt |
Defines the Korean locale. |
app/src/main/java/one/mixin/android/ui/setting/AppearanceFragment.kt |
Adds Korean selection support. |
app/src/main/java/one/mixin/android/ui/setting/ui/page/AppearancePage.kt |
Exposes Spanish and Korean options. |
app/src/main/java/one/mixin/android/ui/wallet/IdentityFragment.kt |
Passes Korean locale to identity verification. |
app/src/main/res/xml/locales_config.xml |
Registers Korean as supported. |
app/src/main/res/values/arrays.xml |
Adds the Korean language name. |
app/src/main/res/values-ko/arrays.xml |
Adds Korean array resources. |
app/src/main/res/values-zh-rTW/strings.xml |
Expands Traditional Chinese strings. |
app/src/main/res/values-zh-rTW/arrays.xml |
Adds Traditional Chinese arrays. |
app/src/main/res/values-zh-rCN/arrays.xml |
Adds localized database labels. |
app/src/main/res/values-ru/strings.xml |
Adds Russian login strings. |
app/src/main/res/values-ru/arrays.xml |
Adds Russian arrays and plurals. |
app/src/main/res/values-ms/arrays.xml |
Completes Malay arrays. |
app/src/main/res/values-ja/strings.xml |
Fixes and expands Japanese strings. |
app/src/main/res/values-ja/arrays.xml |
Completes Japanese arrays. |
app/src/main/res/values-in/arrays.xml |
Completes Indonesian arrays. |
app/src/main/res/values-es/strings.xml |
Adds Spanish login strings. |
app/src/main/res/values-es/arrays.xml |
Adds Spanish arrays and plurals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 25 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
app/src/androidTest/java/one/mixin/android/StringResourceFormatInstrumentedTest.kt:23
- The new format validation only enumerates
R.string, so it never checks plural resources. This PR adds and changes localized<plurals>entries; a mismatched placeholder in any quantity would still escape this test and could fail when formatted viagetQuantityString. Please enumerateR.pluralsand validate each supported quantity as well.
val stringIds = stringResourceIds()
| R.string.member_title_mixin_safe to "Mixin Safe", | ||
| R.string.member_title_mixin_star to "Mixin Star", |
65e2e6f to
bd94c7c
Compare
bd94c7c to
a2bac40
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 34 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
app/src/androidTest/java/one/mixin/android/StringResourceFormatInstrumentedTest.kt:168
- This canonical-name regression test omits
Google_PayandID, so it currently passes even though the new Korean resources override both non-translatable labels. Include them in the map so the test enforces the same contract for these user-visible names.
R.string.Toncoin to "TON",
…tional-and-korean-translations
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 34 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
app/src/androidTest/java/one/mixin/android/StringResourceFormatInstrumentedTest.kt:18
- This validation is under
src/androidTest, but the repository’s only CI workflow runstestGooglePlayDebugUnitTestand never runs instrumentation tests (.github/workflows/android.yml:37-38). As a result, malformed localized format strings will not fail pull requests. Move this to a Robolectric/unit test or add a managed-device/instrumentation test task to CI.
@RunWith(AndroidJUnit4::class)
class StringResourceFormatInstrumentedTest {
No description provided.