Declare only the scopes MEOS does not state - #82
Merged
estebanzimanyi merged 1 commit intoAug 13, 2026
Merged
Conversation
A type-scope declaration stands in for a scope MEOS itself leaves unstated, so it outlives its purpose once the function starts stating one. Three entries describe a state that no longer exists: contained_span_span and span_to_spanset are declared empty, and nad_tcbuffer_stbox is scoped to tcbuffer, because each named a wrapper that serves none of them. Each now names the wrapper that backs it and is that wrapper's only claimant, so no filtering applies to it at all. An empty declaration that outlives its cause is the dangerous one: it stops describing a function that serves none of its wrapper's overloads and starts stripping one that serves all of them. Regenerating against MobilityDB master leaves all 5513 functions' signature lists unchanged, so the three carry no weight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A type-scope declaration stands in for a scope MEOS itself leaves unstated, so
it carries weight only while the function states nothing.
Three entries describe something else.
contained_span_spanandspan_to_spansetare declared empty, andnad_tcbuffer_stboxis scoped totcbuffer, on the grounds that each names a wrapper serving none of them. Eachnames the wrapper that backs it —
Contained_span_span,Span_to_spanset,NAD_tcbuffer_stbox— and is that wrapper's only claimant, so no filteringapplies to it at all.
An empty declaration is the dangerous shape once its cause is gone: it stops
describing a function that serves none of its wrapper's overloads and starts
stripping one that serves all of them.
Regenerating against MobilityDB master leaves all 5513 functions' signature
lists unchanged, so the three carry no weight.
The
t<num>box_shift_scaleentries stay. Their scope derives to the span typestheir bodies manipulate rather than to
tbox, which their wrapper's(tbox, integer|bigint|float)overloads do not match, so removing them costseach of the three its whole surface.
tests/test_family.py::test_representative_symbols_land_in_their_familyandtests/test_struct_layout.py::test_core_structs_have_real_offsetsfail onmaster as well.