fix: override GTFS-RT entity types during populate - #1822
Open
mackenziereading19 wants to merge 1 commit into
Open
fix: override GTFS-RT entity types during populate#1822mackenziereading19 wants to merge 1 commit into
mackenziereading19 wants to merge 1 commit into
Conversation
mackenziereading19
force-pushed
the
fix/1812-override-entity-types
branch
from
September 1, 2026 15:56
be838a0 to
ac71ee4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1812.
GTFS-RT entity types were previously added to the existing relationship during catalogue population rather than replacing the previous catalogue values.
This meant that if a feed changed from, for example:
sa|vpsathe stored result remained
sa|vp.This change clears the existing entity-type relationship before applying a non-empty catalogue
entity_typevalue, so the latest catalogue row replaces the previous values.Regression coverage
Added an integration regression using the existing layered populate fixture:
sa|vpsa["sa"]Before the fix, the test failed with:
['sa', 'vp'] != ['sa']After the fix, it passes.
Tests
Empty
entity_typecell semantics are intentionally unchanged by this patch.