feat: supporting is_seasonal manual set to TDG, JBDA, ODPT - #1830
Open
davidgamez wants to merge 7 commits into
Open
feat: supporting is_seasonal manual set to TDG, JBDA, ODPT#1830davidgamez wants to merge 7 commits into
davidgamez wants to merge 7 commits into
Conversation
davidgamez
marked this pull request as ready for review
September 10, 2026 15:20
Collaborator
|
Out of scope for this PR, but something keeps adding blank lines to OperationsAPI.yaml: mobility-feed-api/docs/OperationsAPI.yaml Lines 2914 to 2921 in f4a31ad There's other locations in the file where blank lines are added. |
Member
Author
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Makes
seasonalan operator-owned, tri-state field so a manual setting survives every automated import and update.operational_status_action(enum includingno_change) withoperational_status(wip|published|unpublished) on the GTFS and GTFS-RT update requests.operational_statusandseasonalare now tri-state: omit to preserve the stored value, send a value to set it. A feed GET response can be sent straight back as an update with no change detected.operational_statusis now exposed viafrom_orm, so it is visible to change detection._PRESERVE_WHEN_OMITTED_FIELDSbackfills omitted tri-state fields from current values to avoid phantom diffs, and the diff becomes the single write gate - theoperational_status_actionspecial case in_populate_feed_valuesand_update_feedis gone.to_ormonly writesseasonal/operational_statuswhen explicitly provided.OPERATOR_OWNED_FEED_COLUMNS = ("seasonal",). No upstream source carries a seasonality signal, so importers never assign it. TDG additionally carriesseasonalacross the delete/recreate path when a feed'sdata_typeflips.CriterionContribution.statusis redocumented as the debounced verdict; the at-risk state is nowpasswithin_grace_periodtrue rather thanfail.Note:
operational_status_action→operational_statusis a breaking spec change.Expected behavior:
seasonaloroperational_status→ stored values unchanged, 204 (no needless materialized view refresh or web revalidation).data_typechange.Testing tips: