feat: seal available compliant by Alessandro100 · Pull Request #196 · MobilityData/mobilitydatabase-web

Alessandro100 · 2026-09-10T17:15:19Z

Summary:

closes #187

Includes the seal of reliability criteria: available and compliant
Also fixes a bug regarding the session cookie
To reduce complexity, removed the feature flag for making the API call in the server side

Expected behavior:

It should display the correct visualizations for the criteria available and compliant based on their reliability status

Testing tips:

Using the following feed ids assure that the correct UI elements and expected state are displayed

"seal_dev_available_fail"
"seal_dev_available_fail_first_check"
"seal_dev_available_probation"
"seal_dev_available_grace_period"
"seal_dev_compliant_fail"
"seal_dev_compliant_grace_period"
"seal_dev_compliant_probation"
"seal_dev_full_pass"
"seal_dev_in_grace_period"
"seal_dev_multi_probation"

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

vercel · 2026-09-10T17:15:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
mobilitydatabase-web	Ready	Preview	Sep 11, 2026 5:56pm UTC

Copilot

🟡 Changes recommended

Data-failure states are missing, and several date, pagination, localization, and accessibility paths can render inaccurate or inaccessible results.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds detailed Available and Compliant Seal of Reliability visualizations to feed pages.

Changes:

Adds availability heatmaps, uptime metrics, compliance summaries, and report links.
Adds grace-period and probation progress displays.
Extends data loading, localization, skeletons, and tests.

Applied Vercel React/Next.js performance guidance.

File summaries

File	Description
`src/app/utils/date.ts`	Adds month formatting.
`src/app/screens/Feed/lib/compliance-report.ts`	Builds compliance summaries.
`src/app/screens/Feed/lib/compliance-report.spec.ts`	Tests compliance summaries.
`src/app/screens/Feed/lib/availability-history.ts`	Builds availability calendars and summaries.
`src/app/screens/Feed/lib/availability-history.spec.ts`	Tests availability logic.
`src/app/screens/Feed/components/FeedReliabilityView.tsx`	Adds Available and Compliant cards.
`src/app/screens/Feed/components/CriterionSection.tsx`	Supports custom bodies and deadline indicators.
`src/app/screens/Feed/components/CriterionSection.spec.tsx`	Tests new criterion behavior.
`src/app/screens/Feed/components/CriterionProbationProgress.tsx`	Displays probation progress.
`src/app/screens/Feed/components/CriterionGraceCountdown.tsx`	Displays grace-period warnings.
`src/app/screens/Feed/components/ComplianceCriterionBody.tsx`	Renders compliance details.
`src/app/screens/Feed/components/AvailabilityUptimeChip.tsx`	Displays uptime percentage.
`src/app/screens/Feed/components/AvailabilityHeatmap.tsx`	Renders daily availability history.
`src/app/screens/Feed/components/AvailabilityCriterionBody.tsx`	Composes availability details.
`src/app/constants/sealCriteria.ts`	Adds criterion probation-window logic.
`src/app/constants/sealCriteria.spec.ts`	Tests probation aggregation.
`src/app/[locale]/feeds/[feedDataType]/[feedId]/static/seal-of-reliability/page.tsx`	Supplies guest dataset reports.
`src/app/[locale]/feeds/[feedDataType]/[feedId]/lib/seal-analysis-data.ts`	Fetches paginated availability history.
`src/app/[locale]/feeds/[feedDataType]/[feedId]/lib/seal-analysis-data.spec.ts`	Tests history fetching.
`src/app/[locale]/feeds/[feedDataType]/[feedId]/components/SealReliabilitySkeleton.tsx`	Expands the loading skeleton.
`src/app/[locale]/feeds/[feedDataType]/[feedId]/authed/seal-of-reliability/page.tsx`	Supplies authenticated dataset reports.
`messages/fr.json`	Adds French criterion copy.
`messages/en.json`	Adds English criterion copy.

Review details

Suppressed comments (2)

src/app/screens/Feed/components/FeedReliabilityView.tsx:228

This conflates a dataset-endpoint failure with a legitimate latest dataset that has no validation report: fetchDatasets catches failures and returns [], which the guest wrapper can cache for 14 days, so both become undefined here and render “No validation report available.” Issue #187 requires a distinct data-failed state. Carry a dataset fetch-error signal into this page and avoid caching that failure as valid data.

                    report={latestDataset?.validation_report}

src/app/[locale]/feeds/[feedDataType]/[feedId]/lib/seal-analysis-data.ts:75

This month subtraction also overflows at month ends: on August 31, requesting February 31 normalizes the API from value to March 3, so valid February checks are never fetched. Share a UTC-safe, end-of-month-clamping calculation with buildAvailabilityCalendar so the fetched and rendered windows both cover the intended six months.

    Date.UTC(
      now.getUTCFullYear(),
      now.getUTCMonth() - AVAILABILITY_HISTORY_MONTHS,
      now.getUTCDate(),
    ),

Files reviewed: 23/23 changed files
Comments generated: 9
Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ * with room to spare. The cap keeps a feed checked more than once a day from
+ * turning one render into an unbounded page walk.
+ */
+const AVAILABILITY_MAX_PAGES = 2;


github-actions · 2026-09-10T17:26:37Z

*Lighthouse ran on https://mobilitydatabase-cdqticlka-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 92	🟢 94	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-cdqticlka-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 78	🟠 88	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-cdqticlka-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🔴 39	🟢 94	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-cdqticlka-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 99	🟠 84	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-cdqticlka-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 83	🟢 94	🟢 96	🟢 100

emmambd

Great work! Some design/content feedback:

Available component: I think 3 different chips in the right hand corner might be too noisy. Could we move the "x days left" information to the On probation bar and grace period text sections?

For when the validation report fails, revise text to "The latest validation report has 22 errors. Resolve these validation errors to pass this criterion."

We should include a link to the validation report HTML report so the user can troubleshoot further.

As a note, @abigailmbd the path for testing is /feeds/gtfs/{path-in-github-issue}/seal-of-reliability

Alessandro100 · 2026-09-10T18:47:26Z

Fixes done, and the validation report button does exist on normal feeds, this is something omitted from the fake data
ex:

emmambd · 2026-09-10T18:50:38Z

Ah great! LGTM!

abigailmbd

LGTM! Great work with this!

Copilot

🟡 Changes recommended

Month-end calculations, Compliant failure handling, and feature/session gating contain correctness regressions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

src/app/screens/Feed/lib/availability-history.ts:93

This direct month arithmetic has the same month-end rollover problem: for an Aug 31 end date and six months, the grid starts Mar 4, omitting Mar 1–3. Clamp the subtraction to the target month's last day (for example via the corrected subMonthsUtc) and then add one UTC day.
src/app/[locale]/feeds/[feedDataType]/[feedId]/lib/seal-analysis-data.ts:239
Removing the Remote Config check means the global rollout/kill switch no longer gates the dedicated route: a direct /seal-of-reliability request still fetches all three endpoints and renders the analysis while the flag is off; the new client checks only hide links elsewhere. Restore a server-side effective-config check in these loaders/routes, including the authenticated admin-bypass behavior.

function isSealAnalysisApplicable(feedDataType: string): boolean {
  // The three endpoints exist only under /v1/gtfs_feeds.
  return feedDataType === 'gtfs';

Files reviewed: 37/37 changed files
Comments generated: 6
Review effort level: Balanced

+                  <ComplianceCriterionBody
+                    criterion={compliantCriterion}
+                    report={latestDataset?.validation_report}
+                    now={now}


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Alessandro100 added 10 commits September 10, 2026 12:15

updated skeleton loading

be235c5

include latest dataset for reliability view

774bed3

probation window helper functions

10ecc54

availability ui elements

ab1d029

criterion reusable elements: probation and grace period

8672e9c

compliance ui element

a5f596c

date function

d0dd751

available and compliant ui elements

7f546c4

availability data handle

a6b93b2

language keys

106f4a8

Alessandro100 requested a balanced review from Copilot September 10, 2026 17:15

Alessandro100 self-assigned this Sep 10, 2026

Copilot started reviewing on behalf of Alessandro100 September 10, 2026 17:15 View session

Copilot AI reviewed Sep 10, 2026

View reviewed changes

emmambd requested a review from abigailmbd September 10, 2026 17:57

Alessandro100 added 2 commits September 10, 2026 14:06

stronger error handling from availability

fe9ae7c

date utc adjustment

b06916e

vercel Bot deployed to Preview September 10, 2026 18:17 View deployment

stronger error message for compliant

1a1ea59

vercel Bot deployed to Preview September 10, 2026 18:26 View deployment

emmambd reviewed Sep 10, 2026

View reviewed changes

days chip removed and text adjustments

2033ce6

vercel Bot deployed to Preview September 10, 2026 18:48 View deployment

Alessandro100 added 3 commits September 11, 2026 08:06

remote config do not cache errored fetch

c16f4f7

removed feature flag in server api call

1f98692

moved the seal firebase feature flag client side

5c07a74

abigailmbd approved these changes Sep 11, 2026

View reviewed changes

fix session bug on expired cookie

f204b73

vercel Bot deployed to Preview September 11, 2026 14:02 View deployment

Alessandro100 added 4 commits September 11, 2026 10:35

tie date in available now goes with latest date

e7ed810

change available limit logic

cfcb855

updated translations

85c9f74

lint

359693d

vercel Bot deployed to Preview September 11, 2026 14:43 View deployment

unit test

fe65e13

vercel Bot deployed to Preview September 11, 2026 14:50 View deployment

Alessandro100 requested review from davidgamez and a balanced review from Copilot September 11, 2026 14:52

Copilot started reviewing on behalf of Alessandro100 September 11, 2026 14:53 View session

Copilot AI reviewed Sep 11, 2026

View reviewed changes

Alessandro100 and others added 3 commits September 11, 2026 11:08

date improvements

2b51384

auth error strengthening

f95c7de

Potential fix for pull request finding

f89ec89

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

vercel Bot had a problem deploying to Preview September 11, 2026 15:13 Failure

fixing ai mistakes

d999564

vercel Bot deployed to Preview September 11, 2026 15:22 View deployment

update available limit to 200

e68c271

vercel Bot deployed to Preview September 11, 2026 17:56 View deployment

Uh oh!

Conversation

Alessandro100 commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emmambd left a comment

Choose a reason for hiding this comment

Uh oh!

Alessandro100 commented Sep 10, 2026

Uh oh!

emmambd commented Sep 10, 2026

Uh oh!

abigailmbd left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alessandro100 commented Sep 10, 2026 •

edited

Loading

vercel Bot commented Sep 10, 2026 •

edited

Loading

github-actions Bot commented Sep 10, 2026 •

edited

Loading