Skip to content

chore: enable react-hooks/rules-of-hooks and resolve conditional hook calls - #219

Draft
aminamos wants to merge 6 commits into
MobilityData:mainfrom
aminamos:feat/160-eslint-react-hooks
Draft

aminamos wants to merge 6 commits into
MobilityData:mainfrom
aminamos:feat/160-eslint-react-hooks

Conversation

@aminamos

Copy link
Copy Markdown

Summary:

Resolves #160.
Enables react-hooks/rules-of-hooks in ESLint configuration and restructures conditional hook calls in GBFS and feed detail components.

Expected behavior:

Hooks are called in uniform order without conditional invocation branches.

Testing tips:

  1. Checkout feat/160-eslint-react-hooks.
  2. Run yarn lint.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with yarn test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

@aminamos is attempting to deploy a commit to the MobilityData Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Alessandro100
❌ aminamos
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable eslint rule 'react-hooks/rules-of-hooks'

3 participants