Update for embedded_network typings - #1696
Open
cmidgley wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moddable: 9.5.0
Platform: All (TypeScript typings)
A collection of
embedded_networktypings. My prior PR (now closed) tried to be a broad, strict platform forio, but it came with a lot of complexity (I'm guessing that is why it never merged). I finally updated my environment from 5.6.0 to 9.5.0 (!) and started anew on this. I focused only on the types I need, and didn't try to hard type all properties (e.g. usinganysimilar to how the latestiotypings are defined). Hopefully this version is easier to digest! ;-)Note: the
udp.d.tsfile optional ... it just caught my attention that the prototypes were usingnullinstead of what most of your typings use (void). Take it or leave it...!