Have agent sessions re-check for comments before finishing - #60
Conversation
Closes #41. A session can run long enough that new comments arrive while it works, and nothing delivers them to the agent; an agent that finishes without looking again simply misses them. The issue asks for the check on both agent surfaces this repo uses. For Claude sessions, the rule goes in claude.yml's prompt-addendum, which is the input gha provides for exactly this ("Repo-specific instructions appended to Claude's prompt"). No new file, and it sits in the workflow where someone configuring the agent will see it. For Copilot agent sessions, the same rule goes in copilot-instructions.md, which is the file those sessions read. Each half names the other so the two do not drift apart. The wording asks for the same disposition on a late comment as on one present at the start: action it, or reply saying why not, and do not finish while something is unanswered. Scope note: claude-code-review.yml is left alone. It posts a review and exits rather than holding a session open, so there is no window for a comment to arrive mid-run and be missed. Verified: workflow YAML parses and the existing inputs are intact; the added prose passes gha's semantic-line-break, list-item-splice and non-standard-character checks, all three run locally with CI's configuration before pushing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lx1hhHu58mXq9DfJsAxkHn
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…omments-before-ending
|
Claude finished review — View run Confirmed: Stopping Point: Clean stopping point reached — review complete, no further action queued. Revised closing, with the CI claim scoped to what I could actually verify: Caveat on CI: VerdictReady for merge (code-review basis only; CI observed via Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "78f581c27753dc2bfbd838cee0ad6dbdef75c4a9",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Re-checked claude.yml prompt-addendum block scalar and copilot-instructions.md Agent Sessions section for syntax and heading-level consistency; diff against previously-reviewed commit a52d08b7 is empty for both files, confirming no regression was introduced by the intervening merge commits.",
"holistic_assessment": "Change still closes issue 41, still matches lab-manual list and heading conventions; CI checked via gh pr checks only (no exhaustive check-runs instrument available), so full CI rollup remains unverified this session."
}Reviewed commit: 4d1105b |
|
Closes #41.
The problem
A session can run long enough that new comments arrive while it works, and nothing delivers them to the agent. An agent that finishes without looking again simply misses them — a review, a correction, or a change of direction lands after it stopped reading.
Where the rule goes
The issue asks for both agent surfaces this repo uses, so each gets it in its own idiom:
prompt-addendumin.github/workflows/claude.yml.github/copilot-instructions.mdprompt-addendumis the inputghaprovides for precisely this — its description reads "Repo-specific instructions appended to Claude's prompt (e.g. the pre-commit checklist)". Using it means no new file, and the instruction sits in the workflow where someone configuring the agent will actually look. Each half names the other, so the two don't silently drift apart.The wording asks for the same disposition on a late comment as on one present from the start: action it, or reply saying why not, and don't finish while something is unanswered.
Scope note
claude-code-review.ymlis deliberately left alone. It posts a review and exits rather than holding a session open, so there's no window for a comment to arrive mid-run and be missed. Adding the instruction there would be noise.Verification
claude.yml's existinginstall-quarto/checkout-submodulesinputs intactThat last point is deliberate. #58's first push went red on two of those three gates; this one was written to them from the start and checked before it left my hands.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Lx1hhHu58mXq9DfJsAxkHn