chore(submodule): bump macros from 8ce5d0c to a63f1a0 - #137
Merged
Merged
Conversation
Bumps [macros](https://github.com/d-morrison/macros) from `8ce5d0c` to `a63f1a0`. - [Commits](d-morrison/macros@8ce5d0c...a63f1a0) --- updated-dependencies: - dependency-name: macros dependency-version: a63f1a0e01e5b9b339b5a6b4126af5acf99e50b5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 10, 2026
d-morrison
added a commit
that referenced
this pull request
Sep 10, 2026
`Check Non-Standard Characters` has been red on `main` since 2026-08-24, and every PR opened since inherits the failure (e.g. #137, whose own diff touches none of the flagged files). The caller passes no `extensions` input, so it takes the reusable workflow's default in Morrison-Lab/gha. That default is now `.qmd, .R, .md`; `.md` was not in it when the caller was written, so broadening the scope pulled in pre-existing Markdown that had never been scanned. Per this repo's own rule, fix the flagged source rather than relax the check -- scanning `.md` is wanted, since the lab convention bans non-ASCII punctuation in every tracked source file. That rationale does not stop at what CI can see, so this replaces U+2014 with the house `---` form in three groups: - the 4 files CI flagged: CLAUDE.md, .github/copilot-instructions.md, .github/prompts/quarto-review.prompt.md, .github/rulesets/README.md; - 3 tracked Markdown files the checker skips because its `ignored_dirs` hard-codes `.claude`: .claude/commands/new-chapter.md, .claude/commands/render.md, .claude/skills/reprexes/SKILL.md; - 5 files outside the checker's extension set entirely: .github/scripts/clear-changed-freezer.py, .github/workflows/copilot-setup-steps.yml, .github/workflows/preview.yml, _quarto-website.yml and qwt-reveal-toggle.html. All 62 were spaced prose dashes, so no compound hyphenation changed and no executable code changed. Every one sits in a comment or in prose, except the one in clear-changed-freezer.py, which is in that module's docstring -- a string literal, but one nothing reads programmatically. The `---` in qwt-reveal-toggle.html sits inside an HTML comment body where it cannot form `-->`. Verified three ways: gha's own checker at @v2 is clean over 17 files; a scan of every tracked file for all seven banned glyphs (em and en dashes, the four curly quotes, U+00D7) reports 0 hits over the 79 of 82 tracked files that are UTF-8 text, the other 3 being two binaries and the `macros` submodule; and the edited Python and YAML files still parse. Also corrects the caller's scope comment, which still described the pre-migration `.qmd`/`.R` behavior. Closes #138 Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Claude finished review — View run This confirms the diff shown in This matches exactly what was reviewed and approved in the prior round (commit The prior review (posted 2026-09-07T13:27:50Z, #137 (comment) — "Claude finished review") verified:
That verdict still stands. No new findings. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "c61743aadf1a1d5ed74d83de993342156a62ef05",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Only changed path is the macros submodule pointer, moving from 8ce5d0c to a63f1a0 with no other files touched by this PR.",
"holistic_assessment": "Branch merge with main brought unrelated file updates already on main; PR's actual scope remains the single approved submodule bump with no regression risk."
}Reviewed commit: 2cfe811 |
Contributor
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps macros from
8ce5d0ctoa63f1a0.Commits
a63f1a0Merge pull request #80 from d-morrison/79-dim-macro2470021Merge branch 'main' into 79-dim-macroe2e94d4Migrate claude.yml, claude-code-review.yml, and publish.yml to Morrison-Lab/g...1cb5b0cUse \dims instead of \dim to avoid conflict with standard \dim operator (#79)6439682Add \dim macro for annotating expression with dimensions (#79)aa7c9b9Open PR for #79Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)