Skip to content

chore: bump mostro-core to 0.14.1 - #181

Merged
grunch merged 1 commit into
mainfrom
chore/bump-mostro-core-0.14
Jul 28, 2026
Merged

chore: bump mostro-core to 0.14.1#181
grunch merged 1 commit into
mainfrom
chore/bump-mostro-core-0.14

Conversation

@grunch

@grunch grunch commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Bump mostro-core from 0.13.0 to 0.14.1 (crates.io), aligning the CLI with mostrod v0.18.0 which already ships 0.14.1.
  • Staying on 0.13.0 meant any incoming message carrying an action added in 0.14.x (e.g. the Cashu escrow actions AddCashuEscrow, CashuEscrowLocked, CashuPmSignature) failed deserialization and was silently dropped — the exact migration hazard the protocol spec warns about in pay_bond_invoice.md.
  • Transport::GiftWrap is now deprecated upstream (mostro#786). The CLI intentionally keeps it as the v1 fallback until mostrod v0.19.0 removes the path, so the single test-side use gets a scoped #[allow(deprecated)] with a note.

No API changes were needed: the whole test suite and clippy pass clean against 0.14.1.

Test plan

  • cargo build --release — clean
  • cargo test --release — all suites green (~100 tests)
  • cargo clippy --release --all-targets — no warnings

Summary by CodeRabbit

  • Bug Fixes
    • Updated the underlying core component to improve compatibility and reliability.
    • Preserved support for the legacy gift-wrap transport behavior.

Aligns the CLI with mostrod v0.18.0, which already ships mostro-core
0.14.1. Staying on 0.13.0 meant any message carrying an action added in
0.14.x (e.g. the Cashu escrow actions) failed deserialization and was
silently dropped — the exact hazard the protocol spec warns about in
pay_bond_invoice.md.

Transport::GiftWrap is now deprecated upstream (mostro/#786); the CLI
keeps it as the v1 fallback until mostrod v0.19.0 removes the path, so
the single test-side use gets a scoped #[allow(deprecated)].
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d9106402-62d9-4200-83b0-77084bf0b24d

📥 Commits

Reviewing files that changed from the base of the PR and between 5b07eb7 and 035f09d.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • src/util/messaging.rs

Walkthrough

The PR upgrades mostro-core from 0.13.0 to 0.14.1 and annotates the gift-wrap transport mapping test to allow its deprecated upstream variant.

Changes

Dependency and transport compatibility

Layer / File(s) Summary
Dependency and deprecated transport test support
Cargo.toml, src/util/messaging.rs
mostro-core is upgraded to 0.14.1; the gift-wrap mapping test documents the retained fallback and suppresses its deprecation warning.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A bunny bumps the crate with care,
From thirteen to fourteen-one there.
Gift-wrap still hops along the trail,
While warning whispers lose their wail.
Tests keep the old path bright—
Wiggle ears and ship tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: updating the mostro-core dependency to 0.14.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-mostro-core-0.14

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@grunch
grunch merged commit 0db711c into main Jul 28, 2026
6 checks passed
@grunch
grunch deleted the chore/bump-mostro-core-0.14 branch July 28, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant