Skip to content

feat: group rejections for mandatory primary keys - #152

Open
georgeRobertson wants to merge 8 commits into
release_v010from
feature/gr-ndsp-619-add_group_level_rejections
Open

georgeRobertson wants to merge 8 commits into
release_v010from
feature/gr-ndsp-619-add_group_level_rejections

Conversation

@georgeRobertson

Copy link
Copy Markdown
Contributor

TLDR of changes

What kind of changes does this PR introduce?

Tick all that apply

  • fix: A bug fix. Correlates with PATCH in SemVer
  • feat: A new feature. Correlates with MINOR in SemVer
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
  • ci: Changes to CI configuration files and scripts (example scopes: GitLabCI)

Please check if the PR fulfills these requirements

  • I have read and followed the Contributing guidance
  • Docs have been added / updated
  • Tests and Linting in the CI are passing
  • Changes have been reviewed and approved by a Project Maintainer

_orph_rel = entities.get(ORPHANED_RECORD_ENTITY_NAME)
if _orph_rel:
if _orph_rel is not None:
processed = True

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the rel exists (which will likely always be the case if hierarchy present) then if the rel is empty, you'd want to remove the rel but set processed to False to remove the need for further write

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants