RAA-4542 - R4 OAS content updates - #2874
Merged
Merged
Conversation
TomKinghorn
changed the title
TomKinghorn
marked this pull request as ready for review
September 11, 2026 16:39
Comment on lines
+69
to
+71
| - `Content-Type` - this should be the same value that was provided in the `NHSD-eRS-File-MIME-Type` header | ||
| - `Content-Disposition` - this should contain the value returned in the `Content-Disposition` header of the response | ||
| - `Content-Length` - this should be the exact length of the file in bytes and must be the same as the value provided in the `NHSD-eRS-File-Size header` |
Contributor
There was a problem hiding this comment.
Why are we using language like 'should'? i think we can evaluate the wording - Must is more appropriate
kevinmason-nhs
previously approved these changes
Sep 14, 2026
kevinmason-nhs
approved these changes
Sep 15, 2026
Chai0044
approved these changes
Sep 15, 2026
TomKinghorn
force-pushed
the
feature/RAA-4542
branch
from
September 15, 2026 10:16
a24146b to
8e75272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAA-12169
RAA-4542
Updates OAS with changes for R4.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.