Refactor SdsFilter for readabilty - #353
Merged
Merged
Conversation
* Moved SSP Header names into `HeaderConstants`. * Refactor `SdsFilterTest` to use headers from `HeaderConstants` * Renamed method to better reflect their usage. * Refactor code to use more modern switch with pattern matching to improve readability. * Refactor `extractOdsCode` to fluent methods. * Refactor `appendSspHeaderWhenAbsent` to handle the header array values better by using `getFirst` on the HttpHeader object.
MartinWheelerMT
enabled auto-merge (squash)
September 8, 2026 13:09
|
Images built and published to ECR using a Build Id of PR-411-a73c8bc |
Jonopono123
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HeaderConstants.SdsFilterTestto use headers fromHeaderConstantsextractOdsCodeto fluent methods.appendSspHeaderWhenAbsentto handle the header array values better by usinggetFirston the HttpHeader object.Why
Refactor
SdsFilterfor readabiltyType of Change
Please check the option(s) that apply.
Checklist