Reactor SdsRequestBuilder to avoid code duplication - #357
Merged
Merged
Conversation
* Remove duplicated methods in `SdsRequestBuilder` which can easy be called by providing the `interactionUrn`. * Updated `SdsRequestBuilderTest` to reflect these changes and introduce shared `TestConstants`.
* Remove duplicated methods in `SdsRequestBuilder` which can easy be called by providing the `interactionUrn`. * Updated `SdsRequestBuilderTest` to reflect these changes and introduce shared `TestConstants`.
MartinWheelerMT
enabled auto-merge (squash)
September 14, 2026 16:03
|
Images built and published to ECR using a Build Id of PR-420-899478f |
ORybak5
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SdsRequestBuilderwhich can easy be called by providing theinteractionUrn.SdsRequestBuilderTestto reflect these changes and introduce sharedTestConstants.SdsClientto use the updated methods from the refactoredSdsRequestBuilder.SdsClientTeststo reflect these changes.Why
There are a number of places with unnecessary code duplication. This fixes one such instance.
Type of Change
Please check the option(s) that apply.
Checklist