Skip to content

Reactor SdsRequestBuilder to avoid code duplication - #357

Merged
MartinWheelerMT merged 3 commits into
mainfrom
reactor-sdsrequestbuilder
Sep 15, 2026
Merged

MartinWheelerMT merged 3 commits into
mainfrom
reactor-sdsrequestbuilder

Conversation

@MartinWheelerMT

@MartinWheelerMT MartinWheelerMT commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

What

  • Remove duplicated methods in SdsRequestBuilder which can easy be called by providing the interactionUrn.
  • Updated SdsRequestBuilderTest to reflect these changes and introduce shared TestConstants.
  • Refactor SdsClient to use the updated methods from the refactored SdsRequestBuilder.
  • Updated SdsClientTests to reflect these changes.

Why

There are a number of places with unnecessary code duplication. This fixes one such instance.

Type of Change

Please check the option(s) that apply.

  • Internal change (non-breaking change with no effect on functionality affecting end users)

Checklist

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section, if this change will affect end users

* Remove duplicated methods in `SdsRequestBuilder` which can easy be called by providing the `interactionUrn`.
* Updated `SdsRequestBuilderTest` to reflect these changes and introduce shared `TestConstants`.
* Remove duplicated methods in `SdsRequestBuilder` which can easy be called by providing the `interactionUrn`.
* Updated `SdsRequestBuilderTest` to reflect these changes and introduce shared `TestConstants`.
@MartinWheelerMT
MartinWheelerMT requested a review from a team as a code owner September 14, 2026 16:02
@MartinWheelerMT
MartinWheelerMT enabled auto-merge (squash) September 14, 2026 16:03
@github-actions

Copy link
Copy Markdown

Images built and published to ECR using a Build Id of PR-420-899478f

@MartinWheelerMT
MartinWheelerMT merged commit b03290a into main Sep 15, 2026
7 checks passed
@MartinWheelerMT
MartinWheelerMT deleted the reactor-sdsrequestbuilder branch September 15, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants